rebase -i: permit 'drop' of a merge commit

4c063c82e9 (rebase -i: improve error message when picking merge,
2024-05-30) added advice texts for cases when a merge commit is
passed as argument of sequencer command that cannot operate with
a merge commit. However, it forgot about the 'drop' command, so
that in this case the BUG() in the default branch is reached.

Handle 'drop' like 'merge', i.e., permit it without a message.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Johannes Sixt 2025-08-06 19:38:35 +02:00 committed by Junio C Hamano
parent a1cf0cf13a
commit 4d491ade8f
2 changed files with 2 additions and 0 deletions

View File

@ -2683,6 +2683,7 @@ static int check_merge_commit_insn(enum todo_command command)
return error(_("cannot squash merge commit into another commit"));

case TODO_MERGE:
case TODO_DROP:
return 0;

default:

View File

@ -2249,6 +2249,7 @@ test_expect_success 'non-merge commands reject merge commits' '
edit $oid
fixup $oid
squash $oid
drop $oid # acceptable, no advice
EOF
(
set_replace_editor todo &&