Browse Source

cvsserver: detect early of we are up to date and avoid costly rev-list

if the SHA1 of our head matches the last SHA1 seen in the DB, avoid further
processing.

[jc: an "Oops, please amend" patch rolled in]

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
maint
Martin Langhoff 18 years ago committed by Junio C Hamano
parent
commit
49fb940e40
  1. 9
      git-cvsserver.perl

9
git-cvsserver.perl

@ -2184,7 +2184,10 @@ sub update @@ -2184,7 +2184,10 @@ sub update
# first lets get the commit list
$ENV{GIT_DIR} = $self->{git_path};

my $commitinfo = `git-cat-file commit $self->{module} 2>&1`;
my $commitsha1 = `git rev-parse $self->{module}`;
chomp $commitsha1;

my $commitinfo = `git cat-file commit $self->{module} 2>&1`;
unless ( $commitinfo =~ /tree\s+[a-zA-Z0-9]{40}/ )
{
die("Invalid module '$self->{module}'");
@ -2194,6 +2197,10 @@ sub update @@ -2194,6 +2197,10 @@ sub update
my $git_log;
my $lastcommit = $self->_get_prop("last_commit");

if (defined $lastcommit && $lastcommit eq $commitsha1) { # up-to-date
return 1;
}

# Start exclusive lock here...
$self->{dbh}->begin_work() or die "Cannot lock database for BEGIN";


Loading…
Cancel
Save