Browse Source

cvsserver: Don't send mixed messages to clients

After we send I HATE YOU we should probably exit and not happily
continue with I LOVE YOU and further communication.

Most clients will probably just exit and ignore everything we
send after the I HATE YOU and it is not a security problem
either because we don't really care about the user name anyway.

But it is still the right thing to do.

[jc: with a minor fixup to its exit code...]

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.de>
Acked-by: "Martin Langhoff" <martin.langhoff@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
maint
Frank Lichtenheld 18 years ago committed by Junio C Hamano
parent
commit
460c6996e2
  1. 1
      git-cvsserver.perl

1
git-cvsserver.perl

@ -105,6 +105,7 @@ if (@ARGV && $ARGV[0] eq 'pserver') { @@ -105,6 +105,7 @@ if (@ARGV && $ARGV[0] eq 'pserver') {
unless ($line eq 'anonymous') {
print "E Only anonymous user allowed via pserver\n";
print "I HATE YOU\n";
exit;
}
$line = <STDIN>; chomp $line; # validate the password?
$line = <STDIN>; chomp $line;

Loading…
Cancel
Save