kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

config: pass repo to `git_config_get_expiry_in_days()` 

Refactor `git_config_get_expiry_in_days()` to accept a `struct
repository` such that we can get rid of the implicit dependency on
`the_repository`. Rename the function accordingly.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Patrick Steinhardt 2024-08-13 11:14:03 +02:00 committed by Junio C Hamano
parent 87aace129e
commit 44ebcd6254
3 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
config.c
View File

@ -2779,13 +2779,14 @@ int repo_config_get_expiry(struct repository *r, const char *key, const char **o
return ret; return ret;
} }


int git_config_get_expiry_in_days(const char *key, timestamp_t *expiry, timestamp_t now) int repo_config_get_expiry_in_days(struct repository *r, const char *key,
timestamp_t *expiry, timestamp_t now)
{ {
const char *expiry_string; const char *expiry_string;
intmax_t days; intmax_t days;
timestamp_t when; timestamp_t when;


if (git_config_get_string_tmp(key, &expiry_string)) if (repo_config_get_string_tmp(r, key, &expiry_string))
return 1; /* no such thing */ return 1; /* no such thing */


if (git_parse_signed(expiry_string, &days, maximum_signed_value_of_type(int))) { if (git_parse_signed(expiry_string, &days, maximum_signed_value_of_type(int))) {

3
config.h
View File

@ -718,7 +718,8 @@ int repo_config_get_max_percent_split_change(struct repository *r);
int repo_config_get_expiry(struct repository *r, const char *key, const char **output); int repo_config_get_expiry(struct repository *r, const char *key, const char **output);


/* parse either "this many days" integer, or "5.days.ago" approxidate */ /* parse either "this many days" integer, or "5.days.ago" approxidate */
int git_config_get_expiry_in_days(const char *key, timestamp_t *, timestamp_t now); int repo_config_get_expiry_in_days(struct repository *r, const char *key,
timestamp_t *, timestamp_t now);


/** /**
* First prints the error message specified by the caller in `err` and then * First prints the error message specified by the caller in `err` and then

6
rerere.c
View File

@ -1203,8 +1203,10 @@ void rerere_gc(struct repository *r, struct string_list *rr)
if (setup_rerere(r, rr, 0) < 0) if (setup_rerere(r, rr, 0) < 0)
return; return;


git_config_get_expiry_in_days("gc.rerereresolved", &cutoff_resolve, now); repo_config_get_expiry_in_days(the_repository, "gc.rerereresolved",
git_config_get_expiry_in_days("gc.rerereunresolved", &cutoff_noresolve, now); &cutoff_resolve, now);
repo_config_get_expiry_in_days(the_repository, "gc.rerereunresolved",
&cutoff_noresolve, now);
git_config(git_default_config, NULL); git_config(git_default_config, NULL);
dir = opendir(git_path("rr-cache")); dir = opendir(git_path("rr-cache"));
if (!dir) if (!dir)