Browse Source

branch: give a more helpful message on redundant arguments

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Nguyễn Thái Ngọc Duy 12 years ago committed by Junio C Hamano
parent
commit
43722c4d9e
  1. 4
      builtin/branch.c
  2. 4
      t/t3200-branch.sh

4
builtin/branch.c

@ -859,7 +859,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix) @@ -859,7 +859,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
else if (argc == 1)
branch_name = argv[0];
else
usage_with_options(builtin_branch_usage, options);
die(_("cannot edit description of more than one branch"));

strbuf_addf(&branch_ref, "refs/heads/%s", branch_name);
if (!ref_exists(branch_ref.buf)) {
@ -881,7 +881,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix) @@ -881,7 +881,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
else if (argc == 2)
rename_branch(argv[0], argv[1], rename > 1);
else
usage_with_options(builtin_branch_usage, options);
die(_("too many branches for a rename operation"));
} else if (new_upstream) {
struct branch *branch = branch_get(argv[0]);


4
t/t3200-branch.sh

@ -73,8 +73,8 @@ test_expect_success \ @@ -73,8 +73,8 @@ test_expect_success \

test_expect_success \
'git branch -m dumps usage' \
'test_expect_code 129 git branch -m 2>err &&
test_i18ngrep "[Uu]sage: git branch" err'
'test_expect_code 128 git branch -m 2>err &&
test_i18ngrep "too many branches for a rename operation" err'

test_expect_success \
'git branch -m m m/m should work' \

Loading…
Cancel
Save