kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

cat-file: declare loop counter inside for() 

Some code used in this series declares variable i and only uses it
in a for loop, not in any other logic outside the loop.

Change the declaration of i to be inside the for loop for readability.
While at it, we also change its type from int to size_t where the
latter makes more sense.

Helped-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Eric Ju <eric.peijian@gmail.com>
Signed-off-by: Pablo Sabater <pabloosabaterr@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
next
Eric Ju 2026-07-10 18:41:08 +02:00 committed by Junio C Hamano
parent c894dedded
commit 3f565f7c9f
2 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
builtin/cat-file.c
View File

@ -723,14 +723,12 @@ static void dispatch_calls(struct batch_options *opt,
struct strbuf *output,
struct expand_data *data,
struct queued_cmd *cmd,
int nr)
size_t nr)
{
int i;

if (!opt->buffer_output)
die(_("flush is only for --buffer mode"));

for (i = 0; i < nr; i++)
for (size_t i = 0; i < nr; i++)
cmd[i].fn(opt, cmd[i].line, output, data);

fflush(stdout);
@ -738,9 +736,7 @@ static void dispatch_calls(struct batch_options *opt,

static void free_cmds(struct queued_cmd *cmd, size_t *nr)
{
size_t i;

for (i = 0; i < *nr; i++)
for (size_t i = 0; i < *nr; i++)
FREE_AND_NULL(cmd[i].line);

*nr = 0;
@ -767,7 +763,6 @@ static void batch_objects_command(struct batch_options *opt,
size_t alloc = 0, nr = 0;

while (strbuf_getdelim_strip_crlf(&input, stdin, opt->input_delim) != EOF) {
int i;
const struct parse_cmd *cmd = NULL;
const char *p = NULL, *cmd_end;
struct queued_cmd call = {0};
@ -777,7 +772,7 @@ static void batch_objects_command(struct batch_options *opt,
if (isspace(*input.buf))
die(_("whitespace before command: '%s'"), input.buf);

for (i = 0; i < ARRAY_SIZE(commands); i++) {
for (size_t i = 0; i < ARRAY_SIZE(commands); i++) {
if (!skip_prefix(input.buf, commands[i].name, &cmd_end))
continue;


3
fetch-pack.c
View File

@ -1388,9 +1388,8 @@ static void write_fetch_command_and_capabilities(struct strbuf *req_buf,
if (advertise_sid && server_supports_v2("session-id"))
packet_buf_write(req_buf, "session-id=%s", trace2_session_id());
if (server_options && server_options->nr) {
int i;
ensure_server_supports_v2("server-option");
for (i = 0; i < server_options->nr; i++)
for (size_t i = 0; i < server_options->nr; i++)
packet_buf_write(req_buf, "server-option=%s",
server_options->items[i].string);
}