From 3ecb171d2b9aca7b09bf112594977d00925893b4 Mon Sep 17 00:00:00 2001 From: Christian Couder Date: Sun, 6 Jul 2008 06:10:04 +0200 Subject: [PATCH] Fix "config_error_nonbool" used with value instead of key The function "config_error_nonbool", that is defined in "config.c", is used to report an error when a config key in the config file should have a corresponding value but it hasn't. So the parameter to this function should be the key and not the value, because the value is undefined. And it could crash if the value is used. Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- builtin-tag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin-tag.c b/builtin-tag.c index e675206de3..3c97c696a5 100644 --- a/builtin-tag.c +++ b/builtin-tag.c @@ -260,7 +260,7 @@ static int git_tag_config(const char *var, const char *value, void *cb) { if (!strcmp(var, "user.signingkey")) { if (!value) - return config_error_nonbool(value); + return config_error_nonbool(var); set_signingkey(value); return 0; }