kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

builtin/fsck: stop using `the_repository` when checking refs 

We implicitly rely on `the_repository` when checking refs. Refactor this
to instead inject the repository via the callback payload.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Patrick Steinhardt 2026-03-23 16:02:58 +01:00 committed by Junio C Hamano
parent 4c44db7dc5
commit 3ea779432d
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
builtin/fsck.c
View File

@ -574,11 +574,12 @@ static int snapshot_ref(const struct reference *ref, void *cb_data)
return 0;
}

static int fsck_handle_ref(const struct reference *ref, void *cb_data UNUSED)
static int fsck_handle_ref(const struct reference *ref, void *cb_data)
{
struct repository *repo = cb_data;
struct object *obj;

obj = parse_object(the_repository, ref->oid);
obj = parse_object(repo, ref->oid);
obj->flags |= USED;
fsck_put_object_name(&fsck_walk_options,
ref->oid, "%s", ref->name);
@ -665,7 +666,7 @@ static void free_snapshot_refs(struct snapshot *snap)
free(snap->ref);
}

static void process_refs(struct snapshot *snap)
static void process_refs(struct repository *repo, struct snapshot *snap)
{
struct worktree **worktrees, **p;

@ -674,7 +675,7 @@ static void process_refs(struct snapshot *snap)
.name = snap->ref[i].refname,
.oid = &snap->ref[i].oid,
};
fsck_handle_ref(&ref, NULL);
fsck_handle_ref(&ref, repo);
}

if (include_reflogs) {
@ -1095,7 +1096,7 @@ int cmd_fsck(int argc,
}

/* Process the snapshotted refs and the reflogs. */
process_refs(&snap);
process_refs(repo, &snap);

/* If not given any explicit objects, process index files too. */
if (!argc)