Avoid redundant conditions
While `if (i <= 0) ... else if (i > 0) ...` is technically equivalent to `if (i <= 0) ... else ...`, the latter is vastly easier to read because it avoids writing out a condition that is unnecessary. Let's drop such unnecessary conditions. Pointed out by CodeQL. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>maint
parent
6c91162449
commit
3d39bcd98e
2
help.c
2
help.c
|
@ -214,7 +214,7 @@ void exclude_cmds(struct cmdnames *cmds, struct cmdnames *excludes)
|
|||
else if (cmp == 0) {
|
||||
ei++;
|
||||
free(cmds->names[ci++]);
|
||||
} else if (cmp > 0)
|
||||
} else
|
||||
ei++;
|
||||
}
|
||||
|
||||
|
|
|
@ -1437,7 +1437,7 @@ static int udt_do_read(struct unidirectional_transfer *t)
|
|||
transfer_debug("%s EOF (with %i bytes in buffer)",
|
||||
t->src_name, (int)t->bufuse);
|
||||
t->state = SSTATE_FLUSHING;
|
||||
} else if (bytes > 0) {
|
||||
} else {
|
||||
t->bufuse += bytes;
|
||||
transfer_debug("Read %i bytes from %s (buffer now at %i)",
|
||||
(int)bytes, t->src_name, (int)t->bufuse);
|
||||
|
|
Loading…
Reference in New Issue