kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

promisor-remote: reject empty name or URL in advertised remote 

In parse_one_advertised_remote(), we check for a NULL remote name and
remote URL, but not for empty ones. An empty URL seems possible as
url_percent_decode("") doesn't return NULL.

In promisor_config_info_list(), we ignore remotes with empty URLs, so a
Git server should not advertise remotes with empty URLs. It's possible
that a buggy or malicious server would do it though.

So let's tighten the check in parse_one_advertised_remote() to also
reject empty strings at parse time.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Christian Couder 2026-04-07 13:52:37 +02:00 committed by Junio C Hamano
parent 4ed9283b36
commit 3b4f0403d1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
promisor-remote.c
View File

@ -722,7 +722,7 @@ static struct promisor_info *parse_one_advertised_remote(const char *remote_info

string_list_clear(&elem_list, 0);

if (!info->name || !info->url) {
if (!info->name || !*info->name || !info->url || !*info->url) {
warning(_("server advertised a promisor remote without a name or URL: '%s', "
"ignoring this remote"), remote_info);
promisor_info_free(info);