kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

last-modified: keep per-path Bloom filters for wildcard pathspecs 

The last-modified builtin expands the pathspec to a set of literal paths
and builds a Bloom key for each. During the walk it looks those keys up
in the commit's filter to decide whether the commit is worth diffing.
These lookups need `bloom_filter_settings` for the key hashing.

prepare_revision_walk() runs prepare_to_use_bloom_filter() to build the
pathspec key vectors. For a pathspec that cannot be turned into a Bloom
key, such as a top-level wildcard like "*.c", that function gives up and
clears `bloom_filter_settings`.

Restore `bloom_filter_settings` after prepare_revision_walk() so the
per-path check keeps working for wildcard pathspecs.

Signed-off-by: Toon Claes <toon@iotcl.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
seen
Toon Claes 2026-07-17 17:47:02 +02:00 committed by Junio C Hamano
parent 31f4a59adb
commit 3a60e8d356
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
builtin/last-modified.c
View File

@ -360,6 +360,14 @@ static int last_modified_run(struct last_modified *lm)

prepare_revision_walk(&lm->rev);

/*
* prepare_revision_walk() clears bloom_filter_settings for pathspecs
* without a Bloom key. Restore it so the per-path check keeps working.
*/
if (!lm->rev.bloom_filter_settings)
lm->rev.bloom_filter_settings =
get_bloom_filter_settings(lm->rev.repo);

max_count = lm->rev.max_count;

init_active_paths_for_commit(&lm->active_paths);