Browse Source

graph: use strbuf_addchars() to add spaces

strbuf_addf() can be used to add a specific number of space characters
by using the format "%*s" with an empty string and specifying the
desired width.  Use strbuf_addchars() instead as it's shorter, makes the
intent clearer and is a bit more efficient.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
René Scharfe 7 years ago committed by Junio C Hamano
parent
commit
38bdf62b73
  1. 10
      graph.c

10
graph.c

@ -696,12 +696,8 @@ static void graph_pad_horizontally(struct git_graph *graph, struct strbuf *sb,
* This way, fields printed to the right of the graph will remain * This way, fields printed to the right of the graph will remain
* aligned for the entire commit. * aligned for the entire commit.
*/ */
int extra; if (chars_written < graph->width)
if (chars_written >= graph->width) strbuf_addchars(sb, ' ', graph->width - chars_written);
return;

extra = graph->width - chars_written;
strbuf_addf(sb, "%*s", (int) extra, "");
} }


static void graph_output_padding_line(struct git_graph *graph, static void graph_output_padding_line(struct git_graph *graph,
@ -787,7 +783,7 @@ static void graph_output_pre_commit_line(struct git_graph *graph,
if (col->commit == graph->commit) { if (col->commit == graph->commit) {
seen_this = 1; seen_this = 1;
strbuf_write_column(sb, col, '|'); strbuf_write_column(sb, col, '|');
strbuf_addf(sb, "%*s", graph->expansion_row, ""); strbuf_addchars(sb, ' ', graph->expansion_row);
chars_written += 1 + graph->expansion_row; chars_written += 1 + graph->expansion_row;
} else if (seen_this && (graph->expansion_row == 0)) { } else if (seen_this && (graph->expansion_row == 0)) {
/* /*

Loading…
Cancel
Save