kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

Merge branch 'jn/test-lint-unmoor' 

* jn/test-lint-unmoor:
  test-lint: find unportable sed, echo, test, and export usage after &&
maint
Junio C Hamano 2014-06-06 11:38:54 -07:00
parent 3ea8ecc21e 561b46c5c8
commit 3784ba310f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
t/check-non-portable-shell.pl
View File

@ -16,12 +16,12 @@ sub err {


while (<>) { while (<>) {
chomp; chomp;
/^\s*sed\s+-i/ and err 'sed -i is not portable'; /\bsed\s+-i/ and err 'sed -i is not portable';
/^\s*echo\s+-n/ and err 'echo -n is not portable (please use printf)'; /\becho\s+-n/ and err 'echo -n is not portable (please use printf)';
/^\s*declare\s+/ and err 'arrays/declare not portable'; /^\s*declare\s+/ and err 'arrays/declare not portable';
/^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)'; /^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';
/test\s+[^=]*==/ and err '"test a == b" is not portable (please use =)'; /\btest\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';
/^\s*export\s+[^=]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)'; /\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)';
# this resets our $. for each file # this resets our $. for each file
close ARGV if eof; close ARGV if eof;
} }