Browse Source

shortlog: warn the user when there is no input

A simple "git shortlog" outside of a git repository stalls
waiting for an input. Check if that's the case by testing with
isatty() before read_from_stdin(), and warn the user like
"git commit" does in a similar case.

Signed-off-by: Michele Ballabio <barra_cuda@katamail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Michele Ballabio 15 years ago committed by Junio C Hamano
parent
commit
3731449591
  1. 2
      builtin-shortlog.c

2
builtin-shortlog.c

@ -295,6 +295,8 @@ parse_done: @@ -295,6 +295,8 @@ parse_done:
if (!nongit && !rev.pending.nr && isatty(0))
add_head_to_pending(&rev);
if (rev.pending.nr == 0) {
if (isatty(0))
fprintf(stderr, "(reading log message from standard input)\n");
read_from_stdin(&log);
}
else

Loading…
Cancel
Save