kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

builtin-mv: fix use of uninitialized memory. 

Juergen Ruehle noticed that add_slash() tries to strcat()
into uninitialized memory and fails.

Signed-off-by: Junio C Hamano <junkio@cox.net>
maint
Junio C Hamano 2006-08-08 12:21:33 -07:00
parent aa5481c1af
commit 329a304714
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
builtin-mv.c
View File

@ -48,7 +48,8 @@ static const char *add_slash(const char *path)
if (path[len - 1] != '/') { if (path[len - 1] != '/') {
char *with_slash = xmalloc(len + 2); char *with_slash = xmalloc(len + 2);
memcpy(with_slash, path, len); memcpy(with_slash, path, len);
strcat(with_slash + len, "/"); with_slash[len++] = '/';
with_slash[len] = 0;
return with_slash; return with_slash;
} }
return path; return path;