Browse Source

Merge branch 'jk/maint-gitweb-xss' into maint

Fixes an XSS vulnerability in gitweb.

* jk/maint-gitweb-xss:
  gitweb: escape html in rss title
maint
Junio C Hamano 12 years ago
parent
commit
326922fd20
  1. 1
      gitweb/gitweb.perl
  2. 15
      t/t9502-gitweb-standalone-parse-output.sh

1
gitweb/gitweb.perl

@ -8055,6 +8055,7 @@ sub git_feed { @@ -8055,6 +8055,7 @@ sub git_feed {
$feed_type = 'history';
}
$title .= " $feed_type";
$title = esc_html($title);
my $descr = git_get_project_description($project);
if (defined $descr) {
$descr = esc_html($descr);

15
t/t9502-gitweb-standalone-parse-output.sh

@ -185,5 +185,20 @@ test_expect_success 'forks: project_index lists all projects (incl. forks)' ' @@ -185,5 +185,20 @@ test_expect_success 'forks: project_index lists all projects (incl. forks)' '
test_cmp expected actual
'

xss() {
echo >&2 "Checking $1..." &&
gitweb_run "$1" &&
if grep "$TAG" gitweb.body; then
echo >&2 "xss: $TAG should have been quoted in output"
return 1
fi
return 0
}

test_expect_success 'xss checks' '
TAG="<magic-xss-tag>" &&
xss "a=rss&p=$TAG" &&
xss "a=rss&p=foo.git&f=$TAG"
'

test_done

Loading…
Cancel
Save