From 30c7bb249e9b2038dd05271e055d347f84336576 Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Wed, 23 Nov 2005 09:57:54 -0800 Subject: [PATCH] Allow editing of a revert-message I think all commit operations should allow editing of the message (ie we should do this for merges too), but that's _particularly_ true of doing a "git revert". We should always explain why we needed to revert something. This patch adds a "-e" or "--edit" flag to "git revert", although I actually suspect it should be on by default (and we should have a "--no-edit" flag to disable it, probably together with an automatic disable if stdin isn't a terminal). Signed-off-by: Linus Torvalds Signed-off-by: Junio C Hamano --- git-revert.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/git-revert.sh b/git-revert.sh index 4154fe0d15..05bd854f4b 100755 --- a/git-revert.sh +++ b/git-revert.sh @@ -25,7 +25,7 @@ usage () { esac } -no_commit= replay= +no_commit= replay= edit= while case "$#" in 0) break ;; esac do case "$1" in @@ -36,6 +36,9 @@ do -r|--r|--re|--rep|--repl|--repla|--replay) replay=t ;; + -e|--edit) + edit=t + ;; -*) usage ;; @@ -161,6 +164,7 @@ echo >&2 "Finished one $me." # If we are revert, or if our cherry-pick results in a hand merge, # we had better say that the current user is responsible for that. +[ "$edit" ] && ${EDITOR:-${VISUAL:-vi}} .msg case "$no_commit" in '') git-commit -n -F .msg