Browse Source

git_exec_path, execv_git_cmd: ignore empty environment variables

Ignoring empty environment variables is good common practice.
Ignoring --exec-path with empty argument won't harm, too:
if user means current directory, there is a "--exec-path=."

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
maint
Dmitry V. Levin 19 years ago committed by Junio C Hamano
parent
commit
2b6016263c
  1. 4
      exec_cmd.c

4
exec_cmd.c

@ -21,7 +21,7 @@ const char *git_exec_path(void) @@ -21,7 +21,7 @@ const char *git_exec_path(void)
return current_exec_path;

env = getenv("GIT_EXEC_PATH");
if (env) {
if (env && *env) {
return env;
}

@ -43,7 +43,7 @@ int execv_git_cmd(const char **argv) @@ -43,7 +43,7 @@ int execv_git_cmd(const char **argv)
const char *exec_dir = paths[i];
const char *tmp;

if (!exec_dir) continue;
if (!exec_dir || !*exec_dir) continue;

if (*exec_dir != '/') {
if (!getcwd(git_command, sizeof(git_command))) {

Loading…
Cancel
Save