kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

t-reftable-stack: add test for stack iterators 

reftable_stack_init_ref_iterator and reftable_stack_init_log_iterator
as defined by reftable/stack.{c,h} initialize a stack iterator to
iterate over the ref and log records in a reftable stack respectively.
Since these functions are not exercised by any of the existing tests,
add a test for them.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Chandra Pratap 2024-09-08 09:36:01 +05:30 committed by Junio C Hamano
parent e87952443a
commit 2b14ced370
1 changed files with 83 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

83
t/unit-tests/t-reftable-stack.c
View File

@ -544,6 +544,88 @@ static void t_reftable_stack_add(void)
clear_dir(dir);
}

static void t_reftable_stack_iterator(void)
{
struct reftable_write_options opts = { 0 };
struct reftable_stack *st = NULL;
char *dir = get_tmp_dir(__LINE__);
struct reftable_ref_record refs[10] = { 0 };
struct reftable_log_record logs[10] = { 0 };
struct reftable_iterator it = { 0 };
size_t N = ARRAY_SIZE(refs), i;
int err;

err = reftable_new_stack(&st, dir, &opts);
check(!err);

for (i = 0; i < N; i++) {
refs[i].refname = xstrfmt("branch%02"PRIuMAX, (uintmax_t)i);
refs[i].update_index = i + 1;
refs[i].value_type = REFTABLE_REF_VAL1;
set_test_hash(refs[i].value.val1, i);

logs[i].refname = xstrfmt("branch%02"PRIuMAX, (uintmax_t)i);
logs[i].update_index = i + 1;
logs[i].value_type = REFTABLE_LOG_UPDATE;
logs[i].value.update.email = xstrdup("johndoe@invalid");
logs[i].value.update.message = xstrdup("commit\n");
set_test_hash(logs[i].value.update.new_hash, i);
}

for (i = 0; i < N; i++) {
err = reftable_stack_add(st, write_test_ref, &refs[i]);
check(!err);
}

for (i = 0; i < N; i++) {
struct write_log_arg arg = {
.log = &logs[i],
.update_index = reftable_stack_next_update_index(st),
};

err = reftable_stack_add(st, write_test_log, &arg);
check(!err);
}

reftable_stack_init_ref_iterator(st, &it);
reftable_iterator_seek_ref(&it, refs[0].refname);
for (i = 0; ; i++) {
struct reftable_ref_record ref = { 0 };

err = reftable_iterator_next_ref(&it, &ref);
if (err > 0)
break;
check(!err);
check(reftable_ref_record_equal(&ref, &refs[i], GIT_SHA1_RAWSZ));
reftable_ref_record_release(&ref);
}
check_int(i, ==, N);

reftable_iterator_destroy(&it);

reftable_stack_init_log_iterator(st, &it);
reftable_iterator_seek_log(&it, logs[0].refname);
for (i = 0; ; i++) {
struct reftable_log_record log = { 0 };

err = reftable_iterator_next_log(&it, &log);
if (err > 0)
break;
check(!err);
check(reftable_log_record_equal(&log, &logs[i], GIT_SHA1_RAWSZ));
reftable_log_record_release(&log);
}
check_int(i, ==, N);

reftable_stack_destroy(st);
reftable_iterator_destroy(&it);
for (i = 0; i < N; i++) {
reftable_ref_record_release(&refs[i]);
reftable_log_record_release(&logs[i]);
}
clear_dir(dir);
}

static void t_reftable_stack_log_normalize(void)
{
int err = 0;
@ -1225,6 +1307,7 @@ int cmd_main(int argc UNUSED, const char *argv[] UNUSED)
TEST(t_reftable_stack_compaction_concurrent_clean(), "compaction with unclean stack shutdown");
TEST(t_reftable_stack_compaction_with_locked_tables(), "compaction with locked tables");
TEST(t_reftable_stack_hash_id(), "read stack with wrong hash ID");
TEST(t_reftable_stack_iterator(), "log and ref iterator for reftable stack");
TEST(t_reftable_stack_lock_failure(), "stack addition with lockfile failure");
TEST(t_reftable_stack_log_normalize(), "log messages should be normalized");
TEST(t_reftable_stack_read_across_reload(), "stack iterators work across reloads");