kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

Makefile: don’t add whatchanged after it has been removed 

07572f220a (whatchanged: remove when built with WITH_BREAKING_CHANGES,
2025-05-12) set up the removal of git-whatchanged(1) when
`WITH_BREAKING_CHANGES` is active.  Part of that work was removing it
from `commands` in `git.c`.  But the Makefile still lists it as a
builtin.  That leaves it in the limbo of being linked but not being
callable; you get the generic error about not being able to call it as
a *builtin*:

    $ git whatchanged
    fatal: cannot handle whatchanged as a builtin

instead of the expected:

    $ git whatchanged
    git: 'whatchanged' is not a git command. See 'git --help'.

Based-on-patch-by: Jeff King <peff@peff.net>
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Kristoffer Haugsbakk 2025-09-17 22:24:11 +02:00 committed by Junio C Hamano
parent c44beea485
commit 29fe658ffb
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -883,7 +883,9 @@ BUILT_INS += git-stage$X
BUILT_INS += git-status$X BUILT_INS += git-status$X
BUILT_INS += git-switch$X BUILT_INS += git-switch$X
BUILT_INS += git-version$X BUILT_INS += git-version$X
ifndef WITH_BREAKING_CHANGES
BUILT_INS += git-whatchanged$X BUILT_INS += git-whatchanged$X
endif


# what 'all' will build but not install in gitexecdir # what 'all' will build but not install in gitexecdir
OTHER_PROGRAMS += git$X OTHER_PROGRAMS += git$X