Browse Source

Merge branch 'rs/mailinfo-qp-decode-fix'

"git mailinfo" was loose in decoding quoted printable and produced
garbage when the two letters after the equal sign are not
hexadecimal.  This has been fixed.

* rs/mailinfo-qp-decode-fix:
  mailinfo: don't decode invalid =XY quoted-printable sequences
maint
Junio C Hamano 7 years ago
parent
commit
2812ca7f0e
  1. 11
      mailinfo.c

11
mailinfo.c

@ -367,11 +367,16 @@ static struct strbuf *decode_q_segment(const struct strbuf *q_seg, int rfc2047) @@ -367,11 +367,16 @@ static struct strbuf *decode_q_segment(const struct strbuf *q_seg, int rfc2047)

while ((c = *in++) != 0) {
if (c == '=') {
int d = *in++;
int ch, d = *in;
if (d == '\n' || !d)
break; /* drop trailing newline */
strbuf_addch(out, (hexval(d) << 4) | hexval(*in++));
continue;
ch = hex2chr(in);
if (ch >= 0) {
strbuf_addch(out, ch);
in += 2;
continue;
}
/* garbage -- fall through */
}
if (rfc2047 && c == '_') /* rfc2047 4.2 (2) */
c = 0x20;

Loading…
Cancel
Save