kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

doc: MyFirstContribution: fix cmd placement instructions 

Using the pull command instead of push is more accurate when giving
instructions on placing the psuh command in alphabetical order.

Signed-off-by: Pedro Sousa <pedroteosousa@gmail.com>
Acked-by: Philip Oakley <philipoakley@iee.email>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Pedro Sousa 2019-09-26 16:05:22 -03:00 committed by Junio C Hamano
parent 5fa0f5238b
commit 24c681794f
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Documentation/MyFirstContribution.txt
View File

@ -97,8 +97,8 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)
---- ----


We'll also need to add the declaration of psuh; open up `builtin.h`, find the We'll also need to add the declaration of psuh; open up `builtin.h`, find the
declaration for `cmd_push`, and add a new line for `psuh` immediately before it, declaration for `cmd_pull`, and add a new line for `psuh` immediately before it,
in order to keep the declarations sorted: in order to keep the declarations alphabetically sorted:


---- ----
int cmd_psuh(int argc, const char **argv, const char *prefix); int cmd_psuh(int argc, const char **argv, const char *prefix);
@ -123,7 +123,7 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)
} }
---- ----


Let's try to build it. Open `Makefile`, find where `builtin/push.o` is added Let's try to build it. Open `Makefile`, find where `builtin/pull.o` is added
to `BUILTIN_OBJS`, and add `builtin/psuh.o` in the same way next to it in to `BUILTIN_OBJS`, and add `builtin/psuh.o` in the same way next to it in
alphabetical order. Once you've done so, move to the top-level directory and alphabetical order. Once you've done so, move to the top-level directory and
build simply with `make`. Also add the `DEVELOPER=1` variable to turn on build simply with `make`. Also add the `DEVELOPER=1` variable to turn on
@ -149,7 +149,7 @@ a `cmd_struct` to the `commands[]` array. `struct cmd_struct` takes a string
with the command name, a function pointer to the command implementation, and a with the command name, a function pointer to the command implementation, and a
setup option flag. For now, let's keep mimicking `push`. Find the line where setup option flag. For now, let's keep mimicking `push`. Find the line where
`cmd_push` is registered, copy it, and modify it for `cmd_psuh`, placing the new `cmd_push` is registered, copy it, and modify it for `cmd_psuh`, placing the new
line in alphabetical order. line in alphabetical order (immediately before `cmd_pull`).


The options are documented in `builtin.h` under "Adding a new built-in." Since The options are documented in `builtin.h` under "Adding a new built-in." Since
we hope to print some data about the user's current workspace context later, we hope to print some data about the user's current workspace context later,
@ -167,7 +167,7 @@ Check it out! You've got a command! Nice work! Let's commit this.


`git status` reveals modified `Makefile`, `builtin.h`, and `git.c` as well as `git status` reveals modified `Makefile`, `builtin.h`, and `git.c` as well as
untracked `builtin/psuh.c` and `git-psuh`. First, let's take care of the binary, untracked `builtin/psuh.c` and `git-psuh`. First, let's take care of the binary,
which should be ignored. Open `.gitignore` in your editor, find `/git-push`, and which should be ignored. Open `.gitignore` in your editor, find `/git-pull`, and
add an entry for your new command in alphabetical order: add an entry for your new command in alphabetical order:


---- ----