kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

sha1-name.c: remove the_repo from interpret_nth_prior_checkout() 

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Nguyễn Thái Ngọc Duy 2019-04-16 16:33:26 +07:00 committed by Junio C Hamano
parent c6c0235b15
commit 23a5712938
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
sha1-name.c
View File

@ -771,7 +771,7 @@ static inline int push_mark(const char *string, int len)
} }


static enum get_oid_result get_oid_1(const char *name, int len, struct object_id *oid, unsigned lookup_flags); static enum get_oid_result get_oid_1(const char *name, int len, struct object_id *oid, unsigned lookup_flags);
static int interpret_nth_prior_checkout(const char *name, int namelen, struct strbuf *buf); static int interpret_nth_prior_checkout(struct repository *r, const char *name, int namelen, struct strbuf *buf);


static int get_oid_basic(const char *str, int len, struct object_id *oid, static int get_oid_basic(const char *str, int len, struct object_id *oid,
unsigned int flags) unsigned int flags)
@ -835,7 +835,7 @@ static int get_oid_basic(const char *str, int len, struct object_id *oid,
struct strbuf buf = STRBUF_INIT; struct strbuf buf = STRBUF_INIT;
int detached; int detached;


if (interpret_nth_prior_checkout(str, len, &buf) > 0) { if (interpret_nth_prior_checkout(the_repository, str, len, &buf) > 0) {
detached = (buf.len == the_hash_algo->hexsz && !get_oid_hex(buf.buf, oid)); detached = (buf.len == the_hash_algo->hexsz && !get_oid_hex(buf.buf, oid));
strbuf_release(&buf); strbuf_release(&buf);
if (detached) if (detached)
@ -1288,7 +1288,8 @@ static int grab_nth_branch_switch(struct object_id *ooid, struct object_id *noid
* Parse @{-N} syntax, return the number of characters parsed * Parse @{-N} syntax, return the number of characters parsed
* if successful; otherwise signal an error with negative value. * if successful; otherwise signal an error with negative value.
*/ */
static int interpret_nth_prior_checkout(const char *name, int namelen, static int interpret_nth_prior_checkout(struct repository *r,
const char *name, int namelen,
struct strbuf *buf) struct strbuf *buf)
{ {
long nth; long nth;
@ -1312,12 +1313,14 @@ static int interpret_nth_prior_checkout(const char *name, int namelen,
cb.remaining = nth; cb.remaining = nth;
strbuf_init(&cb.buf, 20); strbuf_init(&cb.buf, 20);


retval = 0; retval = refs_for_each_reflog_ent_reverse(get_main_ref_store(r),
if (0 < for_each_reflog_ent_reverse("HEAD", grab_nth_branch_switch, &cb)) { "HEAD", grab_nth_branch_switch, &cb);
if (0 < retval) {
strbuf_reset(buf); strbuf_reset(buf);
strbuf_addbuf(buf, &cb.buf); strbuf_addbuf(buf, &cb.buf);
retval = brace - name + 1; retval = brace - name + 1;
} } else
retval = 0;


strbuf_release(&cb.buf); strbuf_release(&cb.buf);
return retval; return retval;
@ -1484,7 +1487,7 @@ int repo_interpret_branch_name(struct repository *r,
namelen = strlen(name); namelen = strlen(name);


if (!allowed || (allowed & INTERPRET_BRANCH_LOCAL)) { if (!allowed || (allowed & INTERPRET_BRANCH_LOCAL)) {
len = interpret_nth_prior_checkout(name, namelen, buf); len = interpret_nth_prior_checkout(the_repository, name, namelen, buf);
if (!len) { if (!len) {
return len; /* syntax Ok, not enough switches */ return len; /* syntax Ok, not enough switches */
} else if (len > 0) { } else if (len > 0) {