remote: fix tear down of struct remote
The remote_clear() function failed to free the remote->push and remote->fetch refspec fields. This should be caught by the leak sanitizer. However, for callers which use ``the_repository``, the values never go out of scope and the sanitizer doesn't complain. A future change is going to add a caller of read_config() for a submodule repository structure, which would result in the leak sanitizer complaining. Fix remote_clear(), updating it to properly call refspec_clear() for both the push and fetch members. Signed-off-by: Jacob Keller <jacob.keller@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>maint
parent
f62dcc7f30
commit
2084f119b4
3
remote.c
3
remote.c
|
@ -165,6 +165,9 @@ static void remote_clear(struct remote *remote)
|
|||
strvec_clear(&remote->url);
|
||||
strvec_clear(&remote->pushurl);
|
||||
|
||||
refspec_clear(&remote->push);
|
||||
refspec_clear(&remote->fetch);
|
||||
|
||||
free((char *)remote->receivepack);
|
||||
free((char *)remote->uploadpack);
|
||||
FREE_AND_NULL(remote->http_proxy);
|
||||
|
|
Loading…
Reference in New Issue