kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

make_absolute_path: return the input path if it points to our buffer 

Some codepaths call make_absolute_path with its own return value as
input. In such a cases, return the path immediately.

This fixes a valgrind-discovered error, whereby we tried to copy a
string onto itself.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Carlos Martín Nieto 2011-03-16 17:06:17 +01:00 committed by Junio C Hamano
parent b406a2d3e3
commit 1d679de58e
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
abspath.c
View File

@ -24,6 +24,10 @@ const char *make_absolute_path(const char *path)
char *last_elem = NULL; char *last_elem = NULL;
struct stat st; struct stat st;


/* We've already done it */
if (path == buf || path == next_buf)
return path;

if (strlcpy(buf, path, PATH_MAX) >= PATH_MAX) if (strlcpy(buf, path, PATH_MAX) >= PATH_MAX)
die ("Too long path: %.*s", 60, path); die ("Too long path: %.*s", 60, path);