kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

configure.ac: upgrade to a compilation check for sysinfo 

Commit f5e3c6c57d ("meson: do a full usage-based compile check for
sysinfo", 2025-04-25) updated the 'sysinfo()' check, as part of the
meson build, due to the failure of the check on Solaris. Prior to
that commit, the meson build only checked the availability of the
'<sys/sysinfo.h>' header file. On Solaris, both the header and the
'sysinfo()' function exist, but are completely unrelated to the same
function on Linux (and cygwin).

Commit 50dec7c566 ("config.mak.uname: add sysinfo() configuration for
cygwin", 2025-04-17) added a similar 'sysinfo()' check to the autoconf
build. This check looked for the 'sysinfo()' function itself, rather
than just the header, but it will fail (incorrectly set HAVE_SYSINFO)
for the same reason.

In order to correctly identify the 'sysinfo()' function we require as
part of 'git-gc' (used in the 'total_ram() function), we also upgrade
to a compilation check, in a similar way to the meson commit. Note that
since commit c9a51775a3 ("builtin/gc.c: correct RAM calculation when
using sysinfo", 2025-04-17) both the 'totalram' and 'mem_unit' fields
of the 'struct sysinfo' are used, so the new check includes both of
those fields in the compile check.

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Ramsay Jones 2025-05-19 17:25:23 +01:00 committed by Junio C Hamano
parent 837f637cf5
commit 187ce0222f
1 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
configure.ac
View File

@ -1069,9 +1069,28 @@ GIT_CONF_SUBST([CHARSET_LIB])

#
# Define HAVE_SYSINFO=YesPlease if sysinfo is available.
GIT_CHECK_FUNC(sysinfo,
[HAVE_SYSINFO=YesPlease],
[HAVE_SYSINFO=])
#
AC_DEFUN([HAVE_SYSINFO_SRC], [
AC_LANG_PROGRAM([[
#include <stdint.h>
#include <sys/sysinfo.h>
]], [[
struct sysinfo si;
uint64_t t = 0;
if (!sysinfo(&si)) {
t = si.totalram;
if (si.mem_unit > 1)
t *= (uint64_t)si.mem_unit;
}
return t;
]])])

AC_MSG_CHECKING([for sysinfo])
AC_COMPILE_IFELSE([HAVE_SYSINFO_SRC],
[AC_MSG_RESULT([yes])
HAVE_SYSINFO=YesPlease],
[AC_MSG_RESULT([no])
HAVE_SYSINFO=])
GIT_CONF_SUBST([HAVE_SYSINFO])

#