Browse Source

Use column indexes in git-cvsserver where necessary.

Tonight I found a git-cvsserver instance spending a lot of time in
disk IO while trying to process operations against a Git repository
with >30,000 objects contained in it.

Blowing away my SQLLite database and rebuilding all tables with
indexes on the attributes that git-cvsserver frequently runs queries
against seems to have resolved the issue quite nicely.

Since the indexes shouldn't hurt performance on small repositories
and always helps on larger repositories we should just always create
them when creating the revision storage tables.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
maint
Shawn Pearce 19 years ago committed by Junio C Hamano
parent
commit
178e015c05
  1. 14
      git-cvsserver.perl

14
git-cvsserver.perl

@ -2118,9 +2118,17 @@ sub new @@ -2118,9 +2118,17 @@ sub new
mode TEXT NOT NULL
)
");
$self->{dbh}->do("
CREATE INDEX revision_ix1
ON revision (name,revision)
");
$self->{dbh}->do("
CREATE INDEX revision_ix2
ON revision (name,commithash)
");
}

# Construct the revision table if required
# Construct the head table if required
unless ( $self->{tables}{head} )
{
$self->{dbh}->do("
@ -2134,6 +2142,10 @@ sub new @@ -2134,6 +2142,10 @@ sub new
mode TEXT NOT NULL
)
");
$self->{dbh}->do("
CREATE INDEX head_ix1
ON head (name)
");
}

# Construct the properties table if required

Loading…
Cancel
Save