From 14058ed717ece27a86dc4c0e72642d89624da5ff Mon Sep 17 00:00:00 2001 From: Elijah Newren Date: Wed, 12 Aug 2026 06:42:38 +0000 Subject: [PATCH] sequencer: remove unnecessary variable setting revs.pretty_given is only ever read in builtin/log.c, and nothing from builtin/log.c is ever called from sequencer.c. So setting this variable cannot do anything. This was introduced in commit 62db524779 ("rebase -i: generate the script via rebase--helper", 2017-07-14), which used `git rev-list` even though its commit message describes the logic as having been based on `git log`. Because of this, I am guessing this line was copied or ported from part of builtin/log.c without recognizing that this line was not doing anything and could be removed. It's certainly not doing anything now, though, so remove it. Signed-off-by: Elijah Newren Signed-off-by: Junio C Hamano --- sequencer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sequencer.c b/sequencer.c index 57855b0066..e395ec4cfc 100644 --- a/sequencer.c +++ b/sequencer.c @@ -6176,7 +6176,6 @@ int sequencer_make_script(struct repository *r, struct strbuf *out, revs.sort_order = REV_SORT_IN_GRAPH_ORDER; revs.topo_order = 1; - revs.pretty_given = 1; repo_config_get_string(the_repository, "rebase.instructionFormat", &format); if (!format || !*format) { free(format);