Merge branch 'jc/do-not-scan-argv-without-parsing'

Update a hard-to-read in-code NEEDSWORK comment.

* jc/do-not-scan-argv-without-parsing:
  rev-list: update a NEEDSWORK comment
maint
Junio C Hamano 2025-08-01 11:27:11 -07:00
commit 152871b88b
1 changed files with 13 additions and 9 deletions

View File

@ -660,17 +660,21 @@ int cmd_rev_list(int argc,
*
* Let "--missing" to conditionally set fetch_if_missing.
*/

/*
* NEEDSWORK: These loops that attempt to find presence of
* options without understanding that the options they are
* skipping are broken (e.g., it would not know "--grep
* NEEDSWORK: The next loop is utterly broken. It tries to
* notice an option is used, but without understanding if each
* option takes an argument, which fundamentally would not
* work. It would not know "--grep
* --exclude-promisor-objects" is not triggering
* "--exclude-promisor-objects" option). We really need
* setup_revisions() to have a mechanism to allow and disallow
* some sets of options for different commands (like rev-list,
* replay, etc). Such a mechanism should do an early parsing
* of options and be able to manage the `--missing=...` and
* `--exclude-promisor-objects` options below.
* "--exclude-promisor-objects" option, for example.
*
* We really need setup_revisions() to have a mechanism to
* allow and disallow some sets of options for different
* commands (like rev-list, replay, etc). Such a mechanism
* should do an early parsing of options and be able to manage
* the `--missing=...` and `--exclude-promisor-objects`
* options below.
*/
for (i = 1; i < argc; i++) {
const char *arg = argv[i];