Browse Source

git-gui: Ensure submodule path is quoted properly

When quoting an arbitrary user string in Tcl, its better to use
[list ...] than to use {...}, in case the user string has spaces
or { embedded within it.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
maint
Shawn O. Pearce 16 years ago
parent
commit
118d938812
  1. 4
      lib/diff.tcl

4
lib/diff.tcl

@ -300,9 +300,9 @@ proc start_show_diff {cont_info {add_opts {}}} {
|| [string match {160000 *} [lindex $s 3]]} { || [string match {160000 *} [lindex $s 3]]} {
set is_submodule_diff 1 set is_submodule_diff 1
if {$w eq $ui_index} { if {$w eq $ui_index} {
set cmd {submodule summary --cached -- $current_diff_path} set cmd [list submodule summary --cached -- $path]
} else { } else {
set cmd {submodule summary --files -- $current_diff_path} set cmd [list submodule summary --files -- $path]
} }
} }



Loading…
Cancel
Save