Browse Source

remove_all_fetch_refspecs(): drop unused "remote" parameter

This function already takes a "key" parameter which uniquely identifies
the config key that we need to remove. There's no need for it to look at
the "remote" parameter at all. Let's drop it in the name of simplicity.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Jeff King 6 years ago committed by Junio C Hamano
parent
commit
113c29ade0
  1. 4
      builtin/remote.c

4
builtin/remote.c

@ -1407,7 +1407,7 @@ static int update(int argc, const char **argv) @@ -1407,7 +1407,7 @@ static int update(int argc, const char **argv)
return retval;
}

static int remove_all_fetch_refspecs(const char *remote, const char *key)
static int remove_all_fetch_refspecs(const char *key)
{
return git_config_set_multivar_gently(key, NULL, NULL, 1);
}
@ -1437,7 +1437,7 @@ static int set_remote_branches(const char *remotename, const char **branches, @@ -1437,7 +1437,7 @@ static int set_remote_branches(const char *remotename, const char **branches,
if (!remote_is_configured(remote, 1))
die(_("No such remote '%s'"), remotename);

if (!add_mode && remove_all_fetch_refspecs(remotename, key.buf)) {
if (!add_mode && remove_all_fetch_refspecs(key.buf)) {
strbuf_release(&key);
return 1;
}

Loading…
Cancel
Save