From be1e04c379c6e80aa7307c208503fdb2b535453d Mon Sep 17 00:00:00 2001 From: Taylor Blau Date: Mon, 22 Oct 2018 18:32:04 -0700 Subject: [PATCH 1/2] Documentation/config.txt: fix typo in core.alternateRefsCommand In [1] Git learned about 'core.alternateRefsCommand', and with it, the accompanying documentation. However, this documentation included a typo involving the verb tense of "produced". Match the tense of the surrounding bits by correcting this typo. [1]: 89284c1d6c (transport.c: introduce core.alternateRefsCommand, 2018-10-08) Signed-off-by: Taylor Blau Signed-off-by: Junio C Hamano --- Documentation/config.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index 3486f9f749..9cef337efe 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -620,7 +620,7 @@ core.alternateRefsCommand:: When advertising tips of available history from an alternate, use the shell to execute the specified command instead of linkgit:git-for-each-ref[1]. The first argument is the absolute path of the alternate. Output must contain one - hex object id per line (i.e., the same as produce by `git for-each-ref + hex object id per line (i.e., the same as produced by `git for-each-ref --format='%(objectname)'`). + Note that you cannot generally put `git for-each-ref` directly into the config From e6641d2fa6d46fbd4bfd6656d5112db0f014dfca Mon Sep 17 00:00:00 2001 From: Jeff King Date: Wed, 24 Oct 2018 03:37:06 -0400 Subject: [PATCH 2/2] t5410: use longer path for sample script t5410 creates a sample script "alternate-refs", and sets core.alternateRefsCommand to just "alternate-refs". That shouldn't work, as "." is not in our $PATH, and so we should not find it. However, due to a bug in run-command.c, we sometimes find it anyway! Even more confusing, this bug is only in the fork-based version of run-command. So the test passes on Linux (etc), but fails on Windows. In preparation for fixing the run-command bug, let's use a more complete path here. Reported-by: Johannes Schindelin Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- t/t5410-receive-pack-alternates.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5410-receive-pack-alternates.sh b/t/t5410-receive-pack-alternates.sh index 457c20c2a5..f00d0da860 100755 --- a/t/t5410-receive-pack-alternates.sh +++ b/t/t5410-receive-pack-alternates.sh @@ -23,7 +23,7 @@ test_expect_success 'with core.alternateRefsCommand' ' --format="%(objectname)" \ refs/heads/public/ EOF - test_config -C fork core.alternateRefsCommand alternate-refs && + test_config -C fork core.alternateRefsCommand ./alternate-refs && git rev-parse public/branch >expect && printf "0000" | git receive-pack fork >actual && extract_haves actual.haves &&