kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

Remove forward declaration of an enum 

According to http://c-faq.com/null/machexamp.html, sizeof(char*) !=
sizeof(int*) on some platforms.  Since an enum could be a char or int
(or long or...), knowing the size of the enum thus is important to
knowing the size of a pointer to an enum, so we cannot just forward
declare an enum the way we can a struct.  (Also, modern C++ compilers
apparently define forward declarations of an enum to either be useless
because the enum was defined, or require an explicit size specifier, or
be a compilation error.)

Helped-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Elijah Newren 2018-08-15 10:54:10 -07:00 committed by Junio C Hamano
parent f790d81252
commit 1076f1e454
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packfile.h
View File

@ -1,12 +1,12 @@
#ifndef PACKFILE_H #ifndef PACKFILE_H
#define PACKFILE_H #define PACKFILE_H


#include "cache.h"
#include "oidset.h" #include "oidset.h"


/* in object-store.h */ /* in object-store.h */
struct packed_git; struct packed_git;
struct object_info; struct object_info;
enum object_type;


/* /*
* Generate the filename to be used for a pack file with checksum "sha1" and * Generate the filename to be used for a pack file with checksum "sha1" and