Browse Source

http.c: Remove bad free of static block

The filename variable here is pointing to a block of memory that
was allocated by sha1_file.c and is also held in a static variable
scoped within the sha1_pack_name() function.  Doing a free() here is
returning that memory to the allocator while we might still try to
reuse it on a subsequent sha1_pack_name() invocation.  That's not
acceptable, so don't free it.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Shawn O. Pearce 15 years ago committed by Junio C Hamano
parent
commit
03b6aeb274
  1. 1
      http.c

1
http.c

@ -1082,7 +1082,6 @@ struct http_pack_request *new_http_pack_request( @@ -1082,7 +1082,6 @@ struct http_pack_request *new_http_pack_request(
return preq;

abort:
free(filename);
free(preq->url);
free(preq);
return NULL;

Loading…
Cancel
Save