From 5ca64e488fcf4574fd1b52f7d523d9f31fbead4f Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Tue, 11 Apr 2006 16:35:39 -0700 Subject: [PATCH 1/5] Retire t5501-old-fetch-and-upload test. Signed-off-by: Junio C Hamano --- t/t5501-old-fetch-and-upload.sh | 48 --------------------------------- 1 file changed, 48 deletions(-) delete mode 100755 t/t5501-old-fetch-and-upload.sh diff --git a/t/t5501-old-fetch-and-upload.sh b/t/t5501-old-fetch-and-upload.sh deleted file mode 100755 index 596c88b1c2..0000000000 --- a/t/t5501-old-fetch-and-upload.sh +++ /dev/null @@ -1,48 +0,0 @@ -#!/bin/sh -# -# Copyright (c) 2005 Johannes Schindelin -# - -# Test that the current fetch-pack/upload-pack plays nicely with -# an old counterpart - -cd $(dirname $0) || exit 1 -: ${SHELL_PATH=/bin/sh} - -tmp=`pwd`/.tmp$$ - -retval=0 - -if [ -z "$1" ]; then - list="fetch upload" -else - list="$@" -fi - -for i in $list; do - case "$i" in - fetch) pgm="old-git-fetch-pack"; replace="$pgm";; - upload) pgm="old-git-upload-pack"; replace="git-fetch-pack --exec=$pgm";; - both) pgm="old-git-upload-pack"; replace="old-git-fetch-pack --exec=$pgm";; - esac - - if where=`LANG=C LC_ALL=C which "$pgm" 2>/dev/null` && - case "$where" in - "no "*) (exit 1) ;; - esac - then - echo "Testing with $pgm" - sed -e "s/git-fetch-pack/$replace/g" \ - -e "s/# old fails/warn/" < t5500-fetch-pack.sh > $tmp - - "$SHELL_PATH" "$tmp" || retval=$? - rm -f "$tmp" - - test $retval != 0 && exit $retval - else - echo "Skipping test for $i, since I cannot find $pgm" - fi -done - -exit 0 - From 684958ae6162c593bd90ba893271ffb2381c3c44 Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Wed, 12 Apr 2006 11:31:23 -0700 Subject: [PATCH 2/5] When showing a commit message, do not lose an incomplete line. --- commit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/commit.c b/commit.c index d534c9ba58..c7bb8dba64 100644 --- a/commit.c +++ b/commit.c @@ -400,11 +400,11 @@ static int get_one_line(const char *msg, unsigned long len) while (len--) { char c = *msg++; + if (!c) + break; ret++; if (c == '\n') break; - if (!c) - return 0; } return ret; } From 475443c8489d9167b944367d8ec8bfef77bee0a5 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Wed, 12 Apr 2006 11:45:18 -0700 Subject: [PATCH 3/5] git-commit: do not muck with commit message when no_edit is set. Spotted by Linus and Darrin Thompson. When we took a commit message from -F with an incomplete line, we appended "git status" output, which ended up attaching a lone "#" at the end. We still need the "do we have anything to commit?" check by running "status" (which has to know what to do in different cases with -i/-o/-a), but there is no point appending its output to the proposed commit message given by the user. Signed-off-by: Junio C Hamano --- git-commit.sh | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/git-commit.sh b/git-commit.sh index 1e7c09e1f2..bd3dc71cd6 100755 --- a/git-commit.sh +++ b/git-commit.sh @@ -537,7 +537,7 @@ t) ;; esac -if [ -f "$GIT_DIR/MERGE_HEAD" ]; then +if test -f "$GIT_DIR/MERGE_HEAD" && test -z "$no_edit"; then echo "#" echo "# It looks like you may be committing a MERGE." echo "# If this is not correct, please remove the file" @@ -605,16 +605,23 @@ else current= fi -{ - test -z "$only_include_assumed" || echo "$only_include_assumed" - run_status -} >>"$GIT_DIR"/COMMIT_EDITMSG +if test -z "$no_edit" +then + { + test -z "$only_include_assumed" || echo "$only_include_assumed" + run_status + } >>"$GIT_DIR"/COMMIT_EDITMSG +else + # we need to check if there is anything to commit + run_status >/dev/null +fi if [ "$?" != "0" -a ! -f "$GIT_DIR/MERGE_HEAD" -a -z "$amend" ] then rm -f "$GIT_DIR/COMMIT_EDITMSG" run_status exit 1 fi + case "$no_edit" in '') case "${VISUAL:-$EDITOR},$TERM" in From f4ee3eb68906f079dea45de4f1bbb03d68189eb3 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Wed, 12 Apr 2006 13:10:27 -0700 Subject: [PATCH 4/5] stripspace: make sure not to leave an incomplete line. When dealing with a commit log message for human consumption, it never makes sense to keep a log that ends with an incomplete line, so make it a part of the clean-up process done by git-stripspace. Acked-by: Linus Torvalds Signed-off-by: Junio C Hamano --- stripspace.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/stripspace.c b/stripspace.c index 96cd0a88f0..dee1ef06ed 100644 --- a/stripspace.c +++ b/stripspace.c @@ -6,9 +6,9 @@ * Remove empty lines from the beginning and end. * * Turn multiple consecutive empty lines into just one - * empty line. + * empty line. Return true if it is an incomplete line. */ -static void cleanup(char *line) +static int cleanup(char *line) { int len = strlen(line); @@ -21,16 +21,19 @@ static void cleanup(char *line) len--; line[len] = 0; } while (len > 1); + return 0; } + return 1; } int main(int argc, char **argv) { int empties = -1; + int incomplete = 0; char line[1024]; while (fgets(line, sizeof(line), stdin)) { - cleanup(line); + incomplete = cleanup(line); /* Not just an empty line? */ if (line[0] != '\n') { @@ -44,5 +47,7 @@ int main(int argc, char **argv) continue; empties++; } + if (incomplete) + putchar('\n'); return 0; } From 8bc7574b6332ef45645c6e0917e9d59919b277ef Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Wed, 12 Apr 2006 13:23:50 -0700 Subject: [PATCH 5/5] combine-diff: type fix. The variable hunk_end points at a line number, which is represented as unsigned long by all the other variables. Signed-off-by: Junio C Hamano --- combine-diff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/combine-diff.c b/combine-diff.c index c45d773659..e519583650 100644 --- a/combine-diff.c +++ b/combine-diff.c @@ -506,8 +506,8 @@ static void dump_sline(struct sline *sline, unsigned long cnt, int num_parent) while (1) { struct sline *sl = &sline[lno]; - int hunk_end; - int rlines; + unsigned long hunk_end; + unsigned long rlines; while (lno <= cnt && !(sline[lno].flag & mark)) lno++; if (cnt < lno)