git/t/chainlint/multi-line-nested-command-s...

(
	foo &&
	x=$(
		echo bar |
		cat
	) &&
	echo ok
) |
sort &&
(
	bar &&
	x=$(echo bar |
		cat
	) &&
	y=$(echo baz |
		fip) &&
	echo fail
)
t/chainlint: add chainlint "nested subshell" test cases The --chain-lint option uses heuristics and knowledge of shell syntax to detect broken &&-chains in subshells by pure textual inspection. The heuristics handle a range of stylistic variations in existing tests (evolved over the years), however, they are still best-guesses. As such, it is possible for future changes to accidentally break assumptions upon which the heuristics are based. Protect against this possibility by adding tests which check the linter itself for correctness. In addition to protecting against regressions, these tests help document (for humans) expected behavior, which is important since the linter's implementation language ('sed') does not necessarily lend itself to easy comprehension. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 7 years ago			`(`
			`foo &&`
			`x=$(`
			`echo bar \|`
			`cat`
			`) &&`
			`echo ok`
			`) \|`
chainlint: recognize multi-line $(...) when command cuddled with "$(" For multi-line $(...) expressions nested within subshells, chainlint.sed only recognizes: x=$( echo foo && ... but it is not unlikely that test authors may also cuddle the command with the opening "$(", so support that style, as well: x=$(echo foo && ... The closing ")" is already correctly recognized when cuddled or not. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 7 years ago			`sort &&`
			`(`
			`bar &&`
			`x=$(echo bar \|`
			`cat`
			`) &&`
			`y=$(echo baz \|`
			`fip) &&`
			`echo fail`
			`)`