From 41722c230c05b4a6ae0eec6c7537a73cb149a65e Mon Sep 17 00:00:00 2001 From: David Gibson Date: Fri, 1 Dec 2006 13:10:07 +1100 Subject: [PATCH] libfdt: Fix logic in nop_property testcase This patch fixes some completely bogus error checking logic from the nop_property testcase (resulted from a cut-and-paste error). Signed-off-by: David Gibson --- tests/nop_property.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/nop_property.c b/tests/nop_property.c index a8bed5b..94c8e74 100644 --- a/tests/nop_property.c +++ b/tests/nop_property.c @@ -57,15 +57,15 @@ int main(int argc, char *argv[]) TEST_STRING_1); verbose_printf("string value was \"%s\"\n", strp); err = fdt_nop_property(fdt, 0, "prop-str"); - err = fdt_ptr_error(intp); + if (err) + FAIL("Failed to nop \"prop-str\": %s", fdt_strerror(err)); + + strp = fdt_getprop(fdt, 0, "prop-str", NULL); + err = fdt_ptr_error(strp); if (! err) FAIL("prop-str still present after nopping"); if (err != FDT_ERR_NOTFOUND) FAIL("Unexpected error on second getprop: %s", fdt_strerror(err)); - strp = fdt_getprop(fdt, 0, "prop-str", NULL); - if (fdt_ptr_error(intp) != FDT_ERR_NOTFOUND) - FAIL("prop-str still present after nopping"); - PASS(); }