Browse Source

Make srcpos_{v,}error() more widely useful

Allow them to take a prefix argument giving the general type of error,
which will be useful in future.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
main
David Gibson 11 years ago
parent
commit
0e2d399225
  1. 2
      dtc-parser.y
  2. 12
      srcpos.c
  3. 10
      srcpos.h

2
dtc-parser.y

@ -475,7 +475,7 @@ void print_error(char const *fmt, ...) @@ -475,7 +475,7 @@ void print_error(char const *fmt, ...)
va_list va;

va_start(va, fmt);
srcpos_verror(&yylloc, fmt, va);
srcpos_verror(&yylloc, "Error", fmt, va);
va_end(va);

treesource_error = true;

12
srcpos.c

@ -290,27 +290,27 @@ srcpos_string(struct srcpos *pos) @@ -290,27 +290,27 @@ srcpos_string(struct srcpos *pos)
return pos_str;
}

void
srcpos_verror(struct srcpos *pos, const char *fmt, va_list va)
void srcpos_verror(struct srcpos *pos, const char *prefix,
const char *fmt, va_list va)
{
char *srcstr;

srcstr = srcpos_string(pos);

fprintf(stderr, "Error: %s ", srcstr);
fprintf(stderr, "%s: %s ", prefix, srcstr);
vfprintf(stderr, fmt, va);
fprintf(stderr, "\n");

free(srcstr);
}

void
srcpos_error(struct srcpos *pos, const char *fmt, ...)
void srcpos_error(struct srcpos *pos, const char *prefix,
const char *fmt, ...)
{
va_list va;

va_start(va, fmt);
srcpos_verror(pos, fmt, va);
srcpos_verror(pos, prefix, fmt, va);
va_end(va);
}


10
srcpos.h

@ -107,10 +107,12 @@ extern struct srcpos *srcpos_copy(struct srcpos *pos); @@ -107,10 +107,12 @@ extern struct srcpos *srcpos_copy(struct srcpos *pos);
extern char *srcpos_string(struct srcpos *pos);
extern void srcpos_dump(struct srcpos *pos);

extern void srcpos_verror(struct srcpos *pos, const char *, va_list va)
__attribute__((format(printf, 2, 0)));
extern void srcpos_error(struct srcpos *pos, const char *, ...)
__attribute__((format(printf, 2, 3)));
extern void srcpos_verror(struct srcpos *pos, const char *prefix,
const char *fmt, va_list va)
__attribute__((format(printf, 3, 0)));
extern void srcpos_error(struct srcpos *pos, const char *prefix,
const char *fmt, ...)
__attribute__((format(printf, 3, 4)));

extern void srcpos_set_line(char *f, int l);


Loading…
Cancel
Save