kernel
/
dracut
mirror of https://git.kernel.org/pub/scm/boot/dracut/dracut.git/
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(TEST GETARG): shellcheck

master
Harald Hoyer 2021-03-30 12:20:03 +02:00 committed by Harald Hoyer
parent 718ad799ac
commit 90b9c00695
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
test/TEST-98-GETARG/.shchkdir Normal file
View File

12
test/TEST-98-GETARG/test.sh
View File

@ -3,6 +3,7 @@
# This file is part of dracut. # This file is part of dracut.
# SPDX-License-Identifier: GPL-2.0-or-later # SPDX-License-Identifier: GPL-2.0-or-later


# shellcheck disable=SC2034
TEST_DESCRIPTION="dracut getarg command" TEST_DESCRIPTION="dracut getarg command"


test_check() { test_check() {
@ -20,12 +21,13 @@ test_setup() {
test_run() { test_run() {
set -x set -x
( (
cd "$TESTDIR" cd "$TESTDIR" || exit 1
export CMDLINE='key1=0 key2=val key2=val2 key3=" val 3 " " key 4 ="val4 "key 5=val 5" "key 6=""val 6" key7="foo"bar" baz="end " key8 = val 8 " export CMDLINE='key1=0 key2=val key2=val2 key3=" val 3 " " key 4 ="val4 "key 5=val 5" "key 6=""val 6" key7="foo"bar" baz="end " key8 = val 8 "
"key 9"="val 9"' "key 9"="val 9"'


ret=0 ret=0


unset TEST
declare -A TEST declare -A TEST
TEST=( TEST=(
["key1"]="0" ["key1"]="0"
@ -55,6 +57,7 @@ test_run() {
INVALIDKEYS=("key" "4" "5" "6" "key8" "9" '"' "baz") INVALIDKEYS=("key" "4" "5" "6" "key8" "9" '"' "baz")
for key in "${INVALIDKEYS[@]}"; do for key in "${INVALIDKEYS[@]}"; do
val=$(./dracut-getarg "$key") val=$(./dracut-getarg "$key")
# shellcheck disable=SC2181
if (($? == 0)); then if (($? == 0)); then
echo "key '$key' should not be found" echo "key '$key' should not be found"
ret=$((ret + 1)) ret=$((ret + 1))
@ -93,7 +96,7 @@ test_run() {
} }


getcmdline() { getcmdline() {
echo "rdbreak=cmdline rd.lvm rd.auto rd.retry=10" echo "rdbreak=cmdline rd.lvm rd.auto=0 rd.auto rd.retry=10"
} }
RDRETRY=$(getarg rd.retry -d 'rd_retry=') RDRETRY=$(getarg rd.retry -d 'rd_retry=')
[[ $RDRETRY == "10" ]] || ret=$((ret + 1)) [[ $RDRETRY == "10" ]] || ret=$((ret + 1))
@ -102,7 +105,7 @@ test_run() {
getargbool 0 rd.auto || ret=$((ret + 1)) getargbool 0 rd.auto || ret=$((ret + 1))


getcmdline() { getcmdline() {
echo "rd.break=cmdlined rd.lvm=0 rd.auto=0" echo "rd.break=cmdlined rd.lvm=0 rd.auto rd.auto=1 rd.auto=0"
} }
getarg rd.break=cmdline -d rdbreak=cmdline && ret=$((ret + 1)) getarg rd.break=cmdline -d rdbreak=cmdline && ret=$((ret + 1))
getargbool 1 rd.lvm -d -n rd_NO_LVM && ret=$((ret + 1)) getargbool 1 rd.lvm -d -n rd_NO_LVM && ret=$((ret + 1))
@ -148,4 +151,5 @@ test_cleanup() {
return 0 return 0
} }


. $testdir/test-functions # shellcheck disable=SC1090
. "$testdir"/test-functions