From 2e3e2e08207a1119c6b59ceacf1901dbf7867f39 Mon Sep 17 00:00:00 2001 From: Harald Hoyer Date: Fri, 26 Mar 2021 10:29:30 +0100 Subject: [PATCH] fix(zfcp): shellcheck for modules.d/95zfcp --- modules.d/95zfcp/.shchkdir | 0 modules.d/95zfcp/parse-zfcp.sh | 3 ++- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 modules.d/95zfcp/.shchkdir diff --git a/modules.d/95zfcp/.shchkdir b/modules.d/95zfcp/.shchkdir new file mode 100644 index 00000000..e69de29b diff --git a/modules.d/95zfcp/parse-zfcp.sh b/modules.d/95zfcp/parse-zfcp.sh index 4d0d8b2f..495aa67f 100755 --- a/modules.d/95zfcp/parse-zfcp.sh +++ b/modules.d/95zfcp/parse-zfcp.sh @@ -3,10 +3,11 @@ getargbool 1 rd.zfcp.conf -d -n rd_NO_ZFCPCONF || rm /etc/zfcp.conf for zfcp_arg in $(getargs rd.zfcp -d 'rd_ZFCP='); do - echo $zfcp_arg | grep '^0\.[0-9a-fA-F]\.[0-9a-fA-F]\{4\}\(,0x[0-9a-fA-F]\{16\},0x[0-9a-fA-F]\{16\}\)\?$' > /dev/null + echo "$zfcp_arg" | grep '^0\.[0-9a-fA-F]\.[0-9a-fA-F]\{4\}\(,0x[0-9a-fA-F]\{16\},0x[0-9a-fA-F]\{16\}\)\?$' > /dev/null test $? -ne 0 && die "For argument 'rd.zfcp=$zfcp_arg'\nSorry, invalid format." ( IFS="," + # shellcheck disable=SC2086 set $zfcp_arg echo "$@" >> /etc/zfcp.conf )